Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs - Add dynamic properties best practices docs & include new onDynamicProperties event #856

Merged
merged 2 commits into from
May 15, 2024

Conversation

joepavitt
Copy link
Collaborator

Description

  • Documents the architecture and design pattern used with dynamic properties
  • Adds a new onDynamicProperties function for the data tracker in order to prevent future duplication
    • Implemented this for ui-dropdown, but will be adding tests and further structure in future PRs

Related Issue(s)

Closes #854

@joepavitt joepavitt requested a review from knolleary May 15, 2024 10:30
@joepavitt joepavitt changed the title Docs - Add dynamic properties best practices docs & include new onDynamicProeprties event Docs - Add dynamic properties best practices docs & include new onDynamicProperties event May 15, 2024
Copy link
Member

@knolleary knolleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending one minor typo fix (just to prove I do actually read these PRs)

ui/src/widgets/data-tracker.mjs Outdated Show resolved Hide resolved
Co-authored-by: Nick O'Leary <nick.oleary@gmail.com>
@joepavitt joepavitt merged commit f85cbf9 into main May 15, 2024
2 checks passed
@joepavitt joepavitt deleted the 854-dynamic-props-docs branch May 15, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs - Dynamic Properties - Best Practices
2 participants