Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI Dropdown - Enable dynamic properties #859

Merged
merged 11 commits into from
May 30, 2024
Merged

UI Dropdown - Enable dynamic properties #859

merged 11 commits into from
May 30, 2024

Conversation

joepavitt
Copy link
Collaborator

@joepavitt joepavitt commented May 15, 2024 •
edited
Loading

Description

  • Enables label and multiple as dynamic properties on ui-dropdown
  • Updates documentation on dynamic properties for ui-dropdown
  • Includes example for client-side development of a dynamic property and a recommended coding pattern

Related Issue(s)

Closes #857

@joepavitt joepavitt added size:S - 2 Sizing estimation point task A piece of work that isn't necessarily tied to a specific Epic or Story. and removed size:S - 2 Sizing estimation point task A piece of work that isn't necessarily tied to a specific Epic or Story. labels May 15, 2024
@joepavitt joepavitt requested a review from Steve-Mcl May 15, 2024 16:24
joepavitt and others added 4 commits May 16, 2024 11:08
@joepavitt @Steve-Mcl
Update ui/src/widgets/ui-dropdown/UIDropdown.vue
948bc24 
Co-authored-by: Stephen McLaughlin <44235289+Steve-Mcl@users.noreply.github.com>
@joepavitt @Steve-Mcl
Update nodes/widgets/ui_dropdown.js
4d568b6 
Co-authored-by: Stephen McLaughlin <44235289+Steve-Mcl@users.noreply.github.com>
@joepavitt
Address feedback re: empty string checking
fb646d4
@joepavitt
Move dynamic options to msg.ui_update and update core docs
e6b9e95
@joepavitt joepavitt requested a review from Steve-Mcl May 24, 2024 13:08
@Steve-Mcl
Copy link
Contributor

@joepavitt did you notice conflicts here?

@joepavitt
Copy link
Collaborator Author

I hadn't - thanks for flagging @Steve-Mcl - just resolved

@joepavitt @Steve-Mcl
Update nodes/widgets/ui_dropdown.js
16f24b0 
Co-authored-by: Stephen McLaughlin <44235289+Steve-Mcl@users.noreply.github.com>
Steve-Mcl
Steve-Mcl approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved but with one suggestion about the core widget design - it is not defensive in the article and might be copied carte blanche - I would recommend we dont promote code that developers copy and paste and might glitch the overall dashboard.

@joepavitt @Steve-Mcl
Update docs/contributing/widgets/core-widgets.md
1b66937 
Co-authored-by: Stephen McLaughlin <44235289+Steve-Mcl@users.noreply.github.com>
@joepavitt joepavitt merged commit 8d0ef4d into main May 30, 2024
1 of 2 checks passed
@joepavitt joepavitt deleted the 857-dynamic-props-dropdown branch May 30, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steve-Mcl Steve-Mcl Steve-Mcl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamic Properties: UI Dropdown
2 participants
@joepavitt @Steve-Mcl