Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "disable auto safe mode" option #309

Merged
merged 7 commits into from
Dec 16, 2024
Merged

Conversation

Steve-Mcl
Copy link
Contributor

closes #308

Description

Adds "disable auto safe mode" option

Adds test:

  Launcher
    disable auto safe mode
      ✔ is disabled by default
      ✔ can be set by user

Related Issue(s)

Owner: #308
Parent: FlowFuse/flowfuse#4552

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl requested a review from hardillb December 16, 2024 12:45
lib/launcher.js Outdated Show resolved Hide resolved
lib/launcher.js Outdated Show resolved Hide resolved
Copy link
Contributor

@hardillb hardillb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we need the changes to the got calls?

@Steve-Mcl
Copy link
Contributor Author

Steve-Mcl commented Dec 16, 2024

Why did we need the changes to the got calls?

Only the got() call in loadSettings was supposed to be updated since got.get needed to be mocked in the tests.

e.g. got(someUrl) cannot be mocked so it was changed to got.get(someUrl) permitting me to sinon.stub(got, 'get') in the tests.

@Steve-Mcl Steve-Mcl requested a review from hardillb December 16, 2024 14:31
@hardillb hardillb merged commit c3a1b52 into main Dec 16, 2024
5 checks passed
@hardillb hardillb deleted the 308-disable-auto-safe-mode-option branch December 16, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update launcher to accept and use 'disable auto safe mode' option
2 participants