Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add vector upsert ability #1243

Merged
merged 5 commits into from
Nov 23, 2023
Merged

Conversation

HenryHengZJ
Copy link
Contributor

image

Currently Vector Store has Upsert and Load Existing Index nodes.

  • Problem - when user use an upsert node, and changed some configs on the flow, and start asking question in chat, it causes the upsert to be done again.

  • Solution - combine upsert and load existing into a node, and have a UPSERT button on UI to allow user to manually upsert, hence the node on flow will always load from existing index.

@tirongi
Copy link
Contributor

tirongi commented Nov 21, 2023

In any case upserting nodes should be kept, as they are useful in case you need to create a flow (and hence an API) for upserting documents from a specific folder.
Another solution could be that of having a flag in the node configuration allowing the user to specify if the node should upsert documents or use those already upserted.

@HenryHengZJ
Copy link
Contributor Author

@tirongi in this new update, you have a separate API for upsert:
image

reason we will be deprecating these upserts nodes is because when there is a slight change on the flow, everything will be re-upsert again, and we want to avoid that, leaving user with the options to manually kick off the upsert

@HenryHengZJ
Copy link
Contributor Author

@vinodkiran everything should be addressed. Kindly take a look again

@HenryHengZJ HenryHengZJ merged commit e93ce07 into main Nov 23, 2023
2 checks passed
@vijaykammili
Copy link

@tirongi in this new update, you have a separate API for upsert: image

reason we will be deprecating these upserts nodes is because when there is a slight change on the flow, everything will be re-upsert again, and we want to avoid that, leaving user with the options to manually kick off the upsert

@HenryHengZJ - What is the process to get to this screen? I don't see this screen in the latest build. I see deprecating Vector stores and NEW Vector stores but can't see the screen where you have the upsert button.

hemati pushed a commit to hemati/Flowise that referenced this pull request Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants