-
-
Notifications
You must be signed in to change notification settings - Fork 16.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ENV boolean flag (DATABASE_SSL) for postgres ssl support #1433
Adds ENV boolean flag (DATABASE_SSL) for postgres ssl support #1433
Conversation
This is needed if hosting flowise data on a postgres server that requires ssl. In PostgreSQL v15, the default rds.force_ssl is 1 (on)
thanks @Jaredude ! can you do a search on
|
Will update shortly... @HenryHengZJ I think I got everything. |
Hey @Jaredude and @HenryHengZJ , is there any chance you could also add support to allow connections to Postgres databases that use self-signed certificates? It seems passing in the |
Do you have an example of how the database TypeORM configuration should looks like with self signed certificate? |
@HenryHengZJ , yes. From what I've read, these options are needed to force
OR
So we're effectively disabling the The problem right now, is that I can't actually specify the |
We'd still want to validate a certificate To validate a self signed certificate, we'd need to do something along the following when we call new DataSource
|
I looked into storing the cert values an ENV variables, since I think it would be one of the main purposes to using postgres is to not have to have a file system. It can be done by converting it to base64 first and then we could set the values ssl using the following: It would look like the following:
I don't have a Postgres setup with a self signed cert, but I can certainly modify this existing PR to make a change that allows simple ssl (already done) as well as self-signed ssl support via base64 ENV values. @HenryHengZJ Any preference on whether to keep this PR as is with simple ssl support and make a separate PR for supporting self signed later? |
@Jaredude I think we can keep this PR as simple ssl, and make another separate PR for self signed cert. The self signed cert should take higher priority if both @dkindlund I think this is another issue/PR as you were mentioning about the PG vector integration in Flowise. Currently UI only takes in certain data types like string, number, array, not function, we'll need to figure something out there |
This is needed if hosting flowise data on a postgres server that requires ssl. In PostgreSQL v15, the default rds.force_ssl is 1 (on)