Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/airtable-views #1454

Merged
merged 4 commits into from
Jan 4, 2024
Merged

Conversation

dkindlund
Copy link
Contributor

Hey @HenryHengZJ, this PR adds support to optionally specify an Airtable View ID when using the Airtable document loader node. That way, only the subset of matching records specified in the filter of the View ID will be used by the document loader. Let me know if you have any questions. Thanks!

@dkindlund
Copy link
Contributor Author

Screenshot of the feature working in a chatflow:
image

@HenryHengZJ
Copy link
Contributor

thanks @dkindlund ! can you do a quick yarn lint-fix for the linting issues?

@dkindlund
Copy link
Contributor Author

@HenryHengZJ , done! Let me know if there are any other blockers here.

@dkindlund
Copy link
Contributor Author

Oh, @HenryHengZJ , I forgot to ask -- do we need to increment the version number of the Airtable documentloader from 1.0 to 1.1 as part of this fix as well? I didn't know if that was part of this requirement as well.

@HenryHengZJ
Copy link
Contributor

Oh, @HenryHengZJ , I forgot to ask -- do we need to increment the version number of the Airtable documentloader from 1.0 to 1.1 as part of this fix as well? I didn't know if that was part of this requirement as well.

yep! we usually go with 1.0, to 2.0 and so on

@dkindlund
Copy link
Contributor Author

dkindlund commented Jan 4, 2024

Oh, @HenryHengZJ , I forgot to ask -- do we need to increment the version number of the Airtable documentloader from 1.0 to 1.1 as part of this fix as well? I didn't know if that was part of this requirement as well.

yep! we usually go with 1.0, to 2.0 and so on

@HenryHengZJ, okay, I've bumped the version number of the node as well. Let me know if you're okay to merge this PR.

Copy link
Contributor

@HenryHengZJ HenryHengZJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thanks @dkindlund !

@HenryHengZJ HenryHengZJ merged commit 247f1e9 into FlowiseAI:main Jan 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants