Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix migration with wrong unix timestamp #2958

Merged
merged 1 commit into from
Aug 7, 2024
Merged

fix migration with wrong unix timestamp #2958

merged 1 commit into from
Aug 7, 2024

Conversation

chungyau97
Copy link
Contributor

@chungyau97 chungyau97 commented Aug 7, 2024 •
edited
Loading

Resason for this fix

  1. When new user come in it will always be the last to run.
    problem
  2. sqlite does not check whether column is created.

Solution

  1. Modify 1766759476232 to 1716300000000.
  2. Add check whether column exists in sqlite.

Results

Affect to current user

what will current user see from the fix 1
what will current user see from the fix 2

Affect to new user

what new user will see from the fix 1
what new user will see from the fix 2

@chungyau97 chungyau97 merged commit 5c78f77 into main Aug 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenryHengZJ HenryHengZJ HenryHengZJ approved these changes

@0xi4o 0xi4o Awaiting requested review from 0xi4o

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chungyau97 @HenryHengZJ