Meilisearch - Added metadata as filterable attributes and polling on enqueued tasks #3042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also added a crucial API request for meilisearch, it enables vector search feature on a given host |
HenryHengZJ
approved these changes
Aug 23, 2024
|
you are welcome @HenryHengZJ ! thanks for your review 👍 |
patrickreinan
pushed a commit
to patrickreinan/Flowise
that referenced
this pull request
Sep 3, 2024
…enqueued tasks (FlowiseAI#3042) * added polling for enqueued tasks,metadata filterable * delete index feature with polling on task * added search filter interface * Update pnpm-lock.yaml --------- Co-authored-by: Henry Heng <henryheng@flowiseai.com>
patrickreinan
pushed a commit
to patrickreinan/Flowise
that referenced
this pull request
Sep 3, 2024
…enqueued tasks (FlowiseAI#3042) * added polling for enqueued tasks,metadata filterable * delete index feature with polling on task * added search filter interface * Update pnpm-lock.yaml --------- Co-authored-by: Henry Heng <henryheng@flowiseai.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there! back again with another improvement for Meilisearch component, I added metadata of the input documents to the metadata of meilisearch hits so no metadata information is lost, I also added all of the metadata content as filterable attributes to enable meilisearch filtering through the component. Moreover,some of meilisearch requests return an "enqueuedTask" , it creates an enqueuedTask depending on the request (adddocuments/update/delete/create-index etc...), so it was necessary to add proper polling on these created tasks to ensure correct upserting of large datasets and to avoid taking any action before these tasks are fully completed.
Example: loop on add documents enqueuedTask to ensure that the upsert function does not end before adding documents already happened on meilisearch cloud
This is the shape of the updated component, it is fully tested and working on production environment, feel free to ask about any of the proposed changes. Thanks