Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/langwatch missing returnids #3077

Merged

Conversation

Meltcap
Copy link
Contributor

@Meltcap Meltcap commented Aug 25, 2024

Fixed a bug where I got a missing 'span' when turning on langWatch in Analyse chatflow settings.

Add missing langWatch: {} to onLLMStart and onLLMStart
Revert changes so I can make bugfix branch
Add missing langWatch object to returnIds for missing 'span' bug.
Copy link
Contributor

@HenryHengZJ HenryHengZJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good spot! thanks for the fix

@HenryHengZJ HenryHengZJ merged commit eb595d2 into FlowiseAI:main Aug 25, 2024
2 checks passed
@Meltcap Meltcap deleted the bugfix/langwatch-missing-returnids branch August 25, 2024 12:42
patrickreinan pushed a commit to patrickreinan/Flowise that referenced this pull request Sep 3, 2024
* Update handler.ts

Add missing langWatch: {} to onLLMStart and onLLMStart

* Update handler.ts

Revert changes so I can make bugfix branch

* Update handler.ts - missing langWatch

Add missing langWatch object to returnIds for missing 'span' bug.
patrickreinan pushed a commit to patrickreinan/Flowise that referenced this pull request Sep 3, 2024
* Update handler.ts

Add missing langWatch: {} to onLLMStart and onLLMStart

* Update handler.ts

Revert changes so I can make bugfix branch

* Update handler.ts - missing langWatch

Add missing langWatch object to returnIds for missing 'span' bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants