Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Introduce boost mode #23

Merged
merged 4 commits into from
Jul 7, 2022
Merged

Conversation

robertlemke
Copy link
Member

This change introduces new configuration options for a "boost mode".

The poll interval should be short enough to process messages in time, and long enough to minimize resource consumption for the database. Boost mode is a solution which automatically handles spikes by processing messages in quick succession. When no new messages appear for a specified time, boost mode is disabled again.

Through this change, pollInterval now also accepts fractions of seconds, for example "0.5" for half a second.

Copy link
Member

@kdambekalns kdambekalns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed ear-to-ear some small fixes to the README are needed.

This change introduces new configuration options for a "boost mode".

The poll interval should be short enough to process messages in time, and long enough to minimize resource consumption for the database. Boost mode is a solution which automatically handles spikes by processing messages in quick succession. When no new messages appear for a specified time, boost mode is disabled again.

Through this change, `pollInterval` now also accepts fractions of seconds, for example "0.5" for half a second.
@kdambekalns kdambekalns changed the title Introduce boost mode FEATURE: Introduce boost mode Jul 6, 2022
@robertlemke robertlemke requested a review from kitsunet July 7, 2022 05:33
Copy link
Member

@kitsunet kitsunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor points, but I don't tihnk any of it is blocking.

README.md Show resolved Hide resolved
Classes/Queue/DoctrineQueue.php Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
# Conflicts:
#	Classes/Queue/DoctrineQueue.php
As per PSR-12 this is the way to go…
@kdambekalns kdambekalns merged commit 2eacf16 into Flowpack:main Jul 7, 2022
@kdambekalns kdambekalns deleted the boost-mode branch July 7, 2022 09:05
Copy link
Collaborator

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great feature, after-the-fact+1 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants