Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mondrian. #73

Merged
merged 2 commits into from
Dec 15, 2021
Merged

Add Mondrian. #73

merged 2 commits into from
Dec 15, 2021

Conversation

muukii
Copy link
Collaborator

@muukii muukii commented Dec 15, 2021 •
edited
Loading

Renames two methods of laying out in favor of this proposal.
#71

view.mondrian.buildSubviews { -> Mondrian.buildSubviews(on: view) {
mondrianBatchLayout { -> Mondrian.layout {

s/([^ ]+).mondrian.buildSubviews \{/Mondrian.buildSubviews(on: $1) {

@muukii
Copy link
Collaborator Author

muukii commented Dec 15, 2021

#71

JohnEstropia
JohnEstropia approved these changes Dec 15, 2021
View reviewed changes
Copy link
Collaborator

@JohnEstropia JohnEstropia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@muukii muukii merged commit 3253f8f into main Dec 15, 2021
@muukii muukii deleted the muukii/align-entrypoint branch December 15, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnEstropia JohnEstropia JohnEstropia approved these changes

Assignees
No one assigned
Labels
Tag: Breaking Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muukii @JohnEstropia