Artifacts/docker #60
Draft
Artifacts/docker #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add multiple boundary condition types for 1D Update naming convention for boundary condition templates * "hbc" stands for "hyperbolic boundary condition" and is meant to be used for boundary conditions on the solution. * "pbc" stands for "parabolic boundary condition" and is meant to be used for boundary conditions on the solution gradients Tests are included that exercise the default boundary conditions for 1d
Still needs scripts for plotting of the solution, but its nearly there
Also removed unused function for converting boundary condition characters to integer flags These changes are made to improve the diff hit on PR #59
Also removed unused private procedure for setting time integrator with integers. Meant to improve diff hit for PR #59
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Currently running into a build issue here with the build in the docker container during the CMake stage What's odd is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #51
This PR adds a Dockerfile for creating a docker image with SELF alongside a Google Cloud Build configuration file for building the image in GCP and storing the image in Fluid Numerics' artifact registry. A build trigger has been configured on Google Cloud to build images on version tags in this repository.
PR #59 should be merged in before this PR is merged.