Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to fix XG System ON sysex message parsing #1171

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Attempt to fix XG System ON sysex message parsing #1171

merged 1 commit into from
Oct 12, 2022

Conversation

derselbst
Copy link
Member

Resolves #1092

@derselbst derselbst added the bug label Oct 8, 2022
@derselbst derselbst mentioned this pull request Oct 8, 2022
Closed
@sonarcloud
Copy link

sonarcloud bot commented Oct 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@jjazzboss
Copy link
Contributor

Looks fine to me.

@derselbst derselbst added this to the 2.3 milestone Oct 12, 2022
@derselbst
Copy link
Member Author

Ok, thanks!

@derselbst derselbst merged commit 4bd635e into master Oct 12, 2022
@derselbst derselbst deleted the xg-sysex-init branch October 12, 2022 18:55
derselbst added a commit that referenced this pull request Dec 20, 2022
@derselbst
Revert "Attempt to fix XG System ON sysex message parsing (#1171)"
4b67aa9 
This reverts commit 4bd635e as it
breaks many MIDI files, see discussion in #1092.
@ReinholdH ReinholdH mentioned this pull request Feb 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.

Expected XG System ON sysex message is wrong
2 participants
@derselbst @jjazzboss