Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated cmake build system #1438

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Conversation

pedrolcl
Copy link
Contributor

  • debug output for libsndfile, quieter output for pulseaudio
  • enhanced build summary report
  • revised building win32 binaries without unicode support

* debug output for libsndfile, quieter output for pulseaudio
* enhanced build summary report
* revised building win32 binaries without unicode support
Copy link
Member

@derselbst derselbst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Pedro! Just a tiny issue below.

CMakeLists.txt Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 24, 2024

@pedrolcl
Copy link
Contributor Author

@carlo-bramini : this branch may be used for debugging the issues you have found with libsndfile. I couldn't reproduce your findings, but added some debug output to the cmake scripts that maybe you find useful for diagnosing the issues.

@pedrolcl pedrolcl requested a review from derselbst November 24, 2024 17:21
@derselbst derselbst merged commit 06ddb9b into FluidSynth:master Nov 25, 2024
50 of 54 checks passed
@pedrolcl pedrolcl deleted the debug-libsndfile branch November 25, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants