Fix bugs in fluid_sample_set_sound_data with copy enabled #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- memset should clear all the memory - end position should be before the end of the memory Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
|
You are right, thanks for the fix. I'll slightly change your wording, then cherry-pick to
Otherwise it's a little confusing, because |
derselbst
pushed a commit
that referenced
this pull request
Oct 21, 2019
- memset should clear all the memory - end position should be before the end of sample data Closes #576 Signed-off-by: Stefan Westerfeld <stefan@space.twc.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While developing liquidsfz, I noticed that clicks occurred at the end of samples but this was fixed if I passed false as copy argument. So I think there are two problems in fluid_sample_set_sound_data: