-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extending package information to asset types other than AssetGenImage. #162
Extending package information to asset types other than AssetGenImage. #162
Conversation
…tter_gen into feature/package-prefix
I'll be checking this PR. |
@wasabeef Do you have any update or feedback? This PR should be especially interesting for projects structured as monorepos using melos. |
@abelokon0711 I want the change to package_parameter_enabled to be another PR. |
@wasabeef I reset the parameter name. After this PR is completed, I will prepare another PR regarding the change to package_parameter_enabled. |
String get packageParameterLiteral => | ||
flutterGen.assets.packageParameterEnabled ? _packageName : ''; | ||
String get packageDependencyLiteral => | ||
flutterGen.assets.packageDependencyEnabled ? _packageName : ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do this too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'll check until this weekend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any update on this?
Codecov Report
@@ Coverage Diff @@
## main #162 +/- ##
=======================================
Coverage 98.95% 98.95%
=======================================
Files 19 19
Lines 574 575 +1
=======================================
+ Hits 568 569 +1
Misses 6 6
Continue to review full report at Codecov.
|
@abelokon0711 |
As for now the package information is only passed to the AssetGenImage class as a parameter.
This PR extends the package information to other asset types.