Make default scale value null so that Flutter decides the one to use #247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have an image with different resolution variants:
At the moment, if you use the generated
image()
method with the default parameters. Eg:It will always use
assets/images/myImage.png
independently of the pixel ratio of the device. This happens because the default parameter ofscale
is1.0
:To workaround this issue at the moment you always have to set
scale
tonull
:Proposed fix:
I believe the default value of
scale
should not be1.0
butnull
as it is in the Flutter'sImage.asset
constructor.