Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate sorted statements #27

Merged
merged 4 commits into from
Sep 8, 2020
Merged

Generate sorted statements #27

merged 4 commits into from
Sep 8, 2020

Conversation

lcdsmao
Copy link
Member

@lcdsmao lcdsmao commented Sep 8, 2020

What does this change?

Generate sorted statements

What is the value of this and can you measure success?

CI Pass

@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #27 into main will increase coverage by 1.67%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   93.87%   95.54%   +1.67%     
==========================================
  Files          15       15              
  Lines         359      359              
==========================================
+ Hits          337      343       +6     
+ Misses         22       16       -6     
Impacted Files Coverage Δ
lib/src/settings/color_path.dart 100.00% <ø> (+60.00%) ⬆️
lib/src/generators/colors_generator.dart 95.45% <100.00%> (+0.10%) ⬆️
lib/src/generators/fonts_generator.dart 100.00% <100.00%> (ø)
lib/src/settings/asset_type.dart 100.00% <100.00%> (ø)
lib/src/settings/flutter.dart 100.00% <0.00%> (ø)
lib/src/settings/flutter_gen.dart 95.45% <0.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f40ab36...b150d12. Read the comment docs.

@lcdsmao lcdsmao changed the title WIP Sort generated statement Sort generated statement Sep 8, 2020
@lcdsmao lcdsmao requested a review from wasabeef September 8, 2020 12:27
@lcdsmao lcdsmao changed the title Sort generated statement Generate sorted statements Sep 8, 2020
@lcdsmao lcdsmao merged commit ca7ccb7 into FlutterGen:main Sep 8, 2020
@lcdsmao lcdsmao deleted the sort branch September 8, 2020 13:15
@wasabeef wasabeef added this to the 1.0.2 milestone Sep 8, 2020
@wasabeef wasabeef mentioned this pull request Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants