Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add some maintainers #422

Merged
merged 1 commit into from
Sep 21, 2023
Merged

chore: Add some maintainers #422

merged 1 commit into from
Sep 21, 2023

Conversation

wasabeef
Copy link
Member

@wasabeef wasabeef commented Sep 21, 2023

What does this change?

Added @AlexV525 @lcdsmao

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
    • Ensure the tests (melos run unit:test)
    • Ensure the analyzer and formatter pass (melos run format to automatically apply formatting)
  • Appropriate docs were updated (if necessary)

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #422 (39bb08f) into main (29ee41c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #422   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files          20       20           
  Lines         691      691           
=======================================
  Hits          679      679           
  Misses         12       12           

Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💙

@wasabeef wasabeef merged commit b0ad6bc into main Sep 21, 2023
5 checks passed
@wasabeef wasabeef deleted the chore-add-maintainers branch September 21, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants