Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Flavored assets #530

Merged
merged 15 commits into from
Jun 24, 2024
Merged

✨ Flavored assets #530

merged 15 commits into from
Jun 24, 2024

Conversation

AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Jun 17, 2024

What does this change?

Resolves #494 🎯

Generated assets would contain the flavor info specified in the pubspec.yaml, but only as a constant that is not involved with actual flavoring.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
    • Ensure the tests (melos run test)
    • Ensure the analyzer and formatter pass (melos run format to automatically apply formatting)
  • Appropriate docs were updated (if necessary)

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.46%. Comparing base (f678d54) to head (54d8499).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #530      +/-   ##
==========================================
+ Coverage   97.27%   97.46%   +0.18%     
==========================================
  Files          22       23       +1     
  Lines         772      829      +57     
==========================================
+ Hits          751      808      +57     
  Misses         21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexV525 AlexV525 marked this pull request as ready for review June 18, 2024 01:47
@wasabeef
Copy link
Member

@AlexV525
Thank you, Ill check.

@AlexV525 AlexV525 force-pushed the feat/compatible-with-flavored-assets branch from 0340f6f to c315e19 Compare June 22, 2024 03:31
@AlexV525
Copy link
Member Author

Please submit issues later if you have any feedback, this is blocking users from generating files if they are using flavors or transformations and there is no workaround for them.

@AlexV525 AlexV525 merged commit 4bf4cdc into main Jun 24, 2024
5 checks passed
@AlexV525 AlexV525 deleted the feat/compatible-with-flavored-assets branch June 24, 2024 05:57
@wasabeef wasabeef mentioned this pull request Jun 25, 2024
wasabeef added a commit that referenced this pull request Jun 25, 2024
## 5.6.0

**Bug fix**
- [#530](#530) Fix the
Flavored assets. by [@AlexV525](https://github.com/AlexV525)
- Please submit issues later if you have any feedback, this is blocking
users from generating files if they are using flavors or transformations
and there is no workaround for them.
- [#532](#532) Provid the
theme to SvgAssetLoader instead of SvgPicture. by
[@Kirpal](https://github.com/Kirpal)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: Conditionally bundling assets based on flavor
2 participants