-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Flavored assets #530
✨ Flavored assets #530
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #530 +/- ##
==========================================
+ Coverage 97.27% 97.46% +0.18%
==========================================
Files 22 23 +1
Lines 772 829 +57
==========================================
+ Hits 751 808 +57
Misses 21 21 ☔ View full report in Codecov by Sentry. |
@AlexV525 |
0340f6f
to
c315e19
Compare
Please submit issues later if you have any feedback, this is blocking users from generating files if they are using flavors or transformations and there is no workaround for them. |
## 5.6.0 **Bug fix** - [#530](#530) Fix the Flavored assets. by [@AlexV525](https://github.com/AlexV525) - Please submit issues later if you have any feedback, this is blocking users from generating files if they are using flavors or transformations and there is no workaround for them. - [#532](#532) Provid the theme to SvgAssetLoader instead of SvgPicture. by [@Kirpal](https://github.com/Kirpal)
What does this change?
Resolves #494 🎯
Generated assets would contain the flavor info specified in the
pubspec.yaml
, but only as a constant that is not involved with actual flavoring.Type of change
Please delete options that are not relevant.
Checklist:
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
melos run test
)melos run format
to automatically apply formatting)