Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Metalhead to 0.8, (keep existing compat) #226

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Metalhead package from 0.7 to 0.7, 0.8.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@ablaom
Copy link
Collaborator

ablaom commented Jul 18, 2023

Metalhead 0.8 is breaking tests because the function Metalhead.vgg_conv_config is no longer defined. The offending line is here.

@darsnack What is the correct way to fix this test for Metalhead 0.8?

@darsnack
Copy link
Member

You can refer to these instead. It should be the same structure but renamed variables.

@DilumAluthge
Copy link
Member

@ablaom Any update here?

@ablaom ablaom mentioned this pull request Aug 23, 2023
@ablaom
Copy link
Collaborator

ablaom commented Aug 23, 2023

Closed in favour of #232

@ablaom ablaom closed this Aug 23, 2023
@DilumAluthge DilumAluthge deleted the compathelper/new_version/2023-06-18-01-02-20-071-01354231790 branch August 23, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants