-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MobileNet v1 #140
Add MobileNet v1 #140
Conversation
src/convnets/mobilenet.jl
Outdated
layers | ||
end | ||
|
||
function MobileNetv1(imsize::NTuple{2, Int} = (224, 224), width_mult = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
function MobileNetv1(imsize::NTuple{2, Int} = (224, 224), width_mult = 1; | |
function MobileNetv1(imsize::Dims{2} = (224, 224), width_mult = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm currently all the models use NTuple{2, Int}
so maybe we'd have to change that across all occurrences for uniformity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure if there were any scenarios where Int
could be something else (some static type, maybe), so I held off from commenting on the earlier model PRs as they left the eltype out. Assuming none of those changes are released, we could always constrain everything to dims and loosen it up if the need arises.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some which are not intended to be Dims
but I left those as is. I did change the rest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are one case (VGG) that has <:Integer
and has been released, but hopefully this PR is straightforward enough to get in before v0.7 is released.
Bump @ToucheSir? |
Adds MobileNet v1 for completeness.