Add basic benchmark harness #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToucheSir
force-pushed
the
bc/benchmarks
branch
6 times, most recently
from
10bf133
to
89c5ebe
Compare
|
Unfortunately it's not possible to compare against master because no such benchmarking code exists there (that's why you'll see this step show up as failed on the latest commit). Therefore, I added an throwaway commit comparing HEAD vs HEAD to show an example of what the output would look like: https://buildkite.com/julialang/nnlib-dot-jl/builds/501#annotation-default. Posting a GH comment would be far more difficult because of secret management and is best left for a future PR. If anyone finds an easier way to access the buildkite link, however, we could do something like what's currently in place for docs previews. |
Co-authored by: Andrei Zhabinski <faithlessfriend@gmail.com>
ToucheSir
force-pushed
the
bc/benchmarks
branch
from
89c5ebe
to
659a853
Compare
darsnack
approved these changes
Oct 21, 2022
|
Nice docs appear to be working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A revamp of @dfdx's work in #304. The main changes here are running benchmarks and rendering the report on Buildkite instead of GHA, because the former gives us runners with >2 threads.
PR Checklist
Tests are addedDocumentation, if applicable