-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EnzymeRules for batchnorm #537
Open
wsmoses
wants to merge
15
commits into
FluxML:master
Choose a base branch
from
wsmoses:batchnorm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Few suggestions ;)
|
There is a weird parsing error in the Code Coverage stage |
Does anyone know about the ubuntu CI error
? |
I couldn't compile the branch on my local machine with Julia 1.9.3. I was also running into problems with parser not figuring out it's the new line, see my comment earlier. Basically code won't compile for me without fixing these. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #536
I made this a separate PR, because for efficiency sake, it is better to have an inplace version of batchnorm, but that wasn't an exported API. Thus I implemented this on the inplace cuda one (which was the only implementation of batchnorm, in place or not).
If NNlib is later refactored to have
batchnorm!
this can go on the refactored rule.