Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove NNPACK and move ForwardDiff to an extension #603

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Aug 29, 2024

  • NNPACK currently cannot be used (has been so since the last minor release). See NNPACK convolution issue #203 (comment). I don't see why they need to be left here
  • Moves ForwardDiff to an extension (any reason why it was left to be loaded via Requires?)
  • As a consequence of the above 2, we can remove the dep on Requires
  • Also Pkg.jl was imported for some reason 😰

@ToucheSir
Copy link
Member

Thanks. I think what happened is that the 1.9 + extensions + Enzyme upgrades took up a lot of energy, leaving none left for cleanup. NNPACK was also a problem because the test coverage was never fixed after it broke a while ago. Either way, we can probably get away with this in a minor release.

@avik-pal avik-pal merged commit f76a38d into FluxML:master Aug 29, 2024
8 of 10 checks passed
@avik-pal avik-pal deleted the ap/load_times branch August 29, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants