Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Adapt #71

Closed
wants to merge 4 commits into from
Closed

Bump Adapt #71

wants to merge 4 commits into from

Conversation

DhairyaLGandhi
Copy link
Member

supersedes #66

@DhairyaLGandhi DhairyaLGandhi changed the title Adapt up Bump Adapt Jun 21, 2020
@devmotion
Copy link
Contributor

It seems Adapt 2 also breaks downstream packages such as Bijectors. Would it be possible to make a bugfix release which is only compatible with Adapt 1 and/or change the bounds in the registry if it takes more time to fix compatibility with Adapt 2?

@DhairyaLGandhi
Copy link
Member Author

DhairyaLGandhi commented Jun 22, 2020

I think the Adapt issue is just JuliaGPU/Adapt.jl#24.

Happy to make a bugfix release but hopefully the adapt fix shouldn't take very long

@devmotion
Copy link
Contributor

Maybe it might be even better to fix https://github.com/JuliaRegistries/General/blob/226d40a90a66e1f947f241363ef607068030f254/T/Tracker/Compat.toml#L45 since it seems Tracker 0.2.7 shouldn't be declared to be compatible with Adapt 2?

@devmotion
Copy link
Contributor

The fix in Adapt fixed the issues in Bijectors, so there's no need for any bugfix releases or other fixes in Tracker from my side any more. Thanks for tracking down the issue so quickly!

@ChrisRackauckas ChrisRackauckas deleted the adapt_up branch August 9, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants