Skip to content

Commit

Permalink
mark as broken the test that fails on 1.0
Browse files Browse the repository at this point in the history
  • Loading branch information
oxinabox committed May 28, 2020
1 parent e7ecdd6 commit 41f4c17
Showing 1 changed file with 11 additions and 3 deletions.
14 changes: 11 additions & 3 deletions test/chainrules.jl
Original file line number Diff line number Diff line change
Expand Up @@ -144,10 +144,18 @@ using Zygote, Test, ChainRules

@test (1,) == h(1)

a3, pb3 = Zygote.pullback(h, 1)
@test ((1,),) == pb3(1)
end

if VERSION > v"1"
a3, pb3 = Zygote.pullback(h, 1)
@test ((1,),) == pb3(1)
else
# broken on Julia 1.0 because of https://github.com/FluxML/Zygote.jl/issues/638
@test_broken begin
a3, pb3 = Zygote.pullback(h, 1); # line that errors
((1,),) == pb3(1) # line actually being tested
end
end
end

@testset "kwargs" begin
kwfoo_rrule_hitcount = Ref(0)
Expand Down

0 comments on commit 41f4c17

Please sign in to comment.