Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Van Gogh family to include Sephiroth APU Revision. #274

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

jontyab
Copy link
Contributor

@jontyab jontyab commented Dec 6, 2023

Van Gogh functionality appears unchanged in the new Sephiroth APU revision used by Steam Deck Oled.

Specifically tested Curve optimizer (--set-coall) which functions well, and --set-cogfx which continues to be silently accepted by SMU but doesn't appear to do anything, consistent with Aerith behaviour.

@FlyGoat
Copy link
Owner

FlyGoat commented Dec 6, 2023

LGTM, besides I can't find much information about Sephiroth, do you think we need to define FAM_SEPHIROTH?

@jontyab
Copy link
Contributor Author

jontyab commented Dec 6, 2023

Spent a lunch-hour googling and made little sense of the naming conventions. Aerith/Sephiroth appear to be valve-internal rather than an APU designation from AMD.

While of course the CPUID is self-reporting a distinct model I'd prefer to group them together if they are architecturally identical and 'just a die shrink' but have struggled to find an authoritative source.

Certainly either just FAM_VANGOGH or both FAM_AERITH + FAM_SEPHIROTH
Doesn't seem right to mix VANGOGH and SEPHIROTH

@FlyGoat
Copy link
Owner

FlyGoat commented Dec 6, 2023

I'm happy with just FAM_VANGOGH then. Will merge.

@FlyGoat FlyGoat merged commit 43bf7ae into FlyGoat:master Dec 6, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants