fix: single ']' character output when no data matches the query #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerMizuyabu
previously approved these changes
May 27, 2024
cmd/list/orgs/orgs.go
Outdated
Comment on lines
45
to
49
| if orgOut != "" { | ||
| orgOut = fmt.Sprintf("%s]", orgOut) | ||
| } else { | ||
| orgOut = "[]" | ||
| } |
There was a problem hiding this comment.
Consider modifying the code to make use of the strings.Join function instead. Something like
orgOut := fmt.Sprintf("[%s]", strings.Join(orgs, ", "))should be able to replace lines 36 to 49
There was a problem hiding this comment.
The same thing can probably be applied to the repos file.
TylerMizuyabu
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE
[#8] - [Bug] single ']' character output when no data matches the query
When no
repositoriesororganizationsare found using one of thelistcommands, a single]character is output. This break JSON parsing libraries that use this output.