Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent duplicate logs by checking whether the stopwatch is actually running #133

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Prevent duplicate logs by checking whether the stopwatch is actually running #133

merged 1 commit into from
Nov 5, 2019

Conversation

GeertvanHorrik
Copy link
Member

Fixes #124 . Note that this only occured to async methods that throw an exception.

This PR adds an additional check in the StopStopwatch method:

image

@GeertvanHorrik GeertvanHorrik self-assigned this Nov 5, 2019
@SimonCropp
Copy link
Member

did u forget to commit a change?

AsyncMethodProcessor.cs(234,56): error CS0103: The name 'stopwatchFieldReference' does not exist in the current context [C:\projects\methodtimer\MethodTimer.Fody\MethodTimer.Fody.csproj]

@GeertvanHorrik
Copy link
Member Author

This relies on the other PR with the generic fixes.

@SimonCropp SimonCropp added this to the 3.1.2 milestone Nov 5, 2019
@SimonCropp SimonCropp merged commit a0da277 into master Nov 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the pr/prevent-duplicate-logs-for-async-methods branch November 5, 2019 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonCropp SimonCropp Awaiting requested review from SimonCropp

Assignees

@GeertvanHorrik GeertvanHorrik

Labels
None yet
Projects
None yet
Milestone
3.1.2
Development

Successfully merging this pull request may close these issues.

Async method that throws Exception not working
2 participants
@GeertvanHorrik @SimonCropp