Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue#220 #253

Merged
merged 2 commits into from
Jun 10, 2017
Merged

Issue#220 #253

merged 2 commits into from
Jun 10, 2017

Conversation

tom-englert
Copy link
Member

@tom-englert tom-englert commented Jun 2, 2017 •
edited
Loading

Fixes #220 (Initializing properties in constructor generates CA2214:DoNotCallOverridableMethodsInConstructors)

@SimonCropp
Copy link
Member

sorry but u will need to rebase

@SimonCropp
Copy link
Member

Looks like it failed ci

@tom-englert
Copy link
Member Author

Fixed; my local changes were not included in the commit after cherry-picking.

@SimonCropp
Copy link
Member

looks good. thanks

@SimonCropp SimonCropp added this to the 2.1.2 milestone Jun 10, 2017
@SimonCropp SimonCropp merged commit 11a91aa into Fody:master Jun 10, 2017
@tom-englert tom-englert deleted the issue#220 branch June 10, 2017 16:45
@navozenko navozenko mentioned this pull request Jun 28, 2017
Closed
SimonCropp added a commit that referenced this pull request Jun 30, 2017
@SimonCropp
revert FixupConstructorAutoPropertyInitializers
b6f7b53 
#253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
2.1.2
Development

Successfully merging this pull request may close these issues.

Initializing properties in constructor generates CA2214:DoNotCallOverridableMethodsInConstructors
2 participants
@tom-englert @SimonCropp