This repository has been archived by the owner on Feb 25, 2023. It is now read-only.
Add support for progressive/perfect inflections #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for ている inflections. Supports ている, てる, ておる, and ないでいる. The first three are all classified as "progressive or perfect", even though one is humble and one is a contraction. The last is classified as "negative « -te « progressive or perfect".
I chose not to add the とる contraction (at least not in this commit) because と would function slightly differently than て, in that it doesn't stand alone as it's own type of inflection like て does. This functionality can be added, but it would take a few changes to the deinflector.
This change does add some "virtual" deinflection rules to prevent the inflections from being used where they don't make sense. The new values include
"iru"and"neg-de", both of which are not intended to match any rules found in dictionary files.Works with both the current deinflector and the updated deinflector in #229. https://www.imabi.net/teiru.htm was used for test cases.