This repository has been archived by the owner on Feb 25, 2023. It is now read-only.
Fix "tags" template #539
Merged
Fix "tags" template #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ext/bg/js/options.js
Outdated
| fieldTemplates += '\n\n' + replacement; | ||
| const replacements = [ | ||
| [ | ||
| '{{#*inline "audio"}}\n {{~#if definition.audioFileName~}}\n [sound:{{definition.audioFileName}}]\n {{~/if~}}\n{{/inline}}', |
There was a problem hiding this comment.
- Flip the order of the
[replacement, pattern]values, since it's kind of apattern => replacementstyle. - Move
new RegExp(escapeRegExp(and), 'g')inside thefor.
siikamiika
commented
May 17, 2020
| @@ -150,7 +150,7 @@ class Backend { | |||
| await profileConditionsDescriptorPromise; | |||
|
|
|||
| this.optionsSchema = await requestJson(chrome.runtime.getURL('/bg/data/options-schema.json'), 'GET'); | |||
| this.defaultAnkiFieldTemplates = await requestText(chrome.runtime.getURL('/bg/data/default-anki-field-templates.handlebars'), 'GET'); | |||
| this.defaultAnkiFieldTemplates = (await requestText(chrome.runtime.getURL('/bg/data/default-anki-field-templates.handlebars'), 'GET')).trim(); | |||
There was a problem hiding this comment.
Is this something that could cause issues in the future? I think it should work fine as long as you don't compare anything with the raw result from the .handlebars file. I did it this way because I've configured my editor to ensure a newline at the end of the file and it was added when I modified the tags template.
There was a problem hiding this comment.
It should probably be fine.
toasted-nutbread
approved these changes
May 17, 2020
|
Merging this on your behalf in your (semi-)absence. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #538. Yet another issue caused by the data format issue of #337.