Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for float type #243

Closed
ForNeVeR opened this issue Aug 17, 2022 · 1 comment · Fixed by #267
Closed

Support for float type #243

ForNeVeR opened this issue Aug 17, 2022 · 1 comment · Fixed by #267
Labels
area:cil-interop Related to CIL (.NET) interop area:compiler Related to code compilation or type checking kind:feature New feature or request status:help-wanted Open for contributors

Comments

@ForNeVeR
Copy link
Owner

ForNeVeR commented Aug 17, 2022 •
edited
Loading

As of #189, we have support for double, but still none for float. We should support that.

A good start is to look for // TODO[#243] in the code.
@ForNeVeR ForNeVeR added kind:feature New feature or request status:help-wanted Open for contributors area:compiler Related to code compilation or type checking good-first-issue An issue considered simple enough for new contributors area:cil-interop Related to CIL (.NET) interop and removed good-first-issue An issue considered simple enough for new contributors labels Aug 17, 2022
@ForNeVeR
Copy link
Owner Author

This turns out to be harder than I thought.

In the C source, all (most?) of the constants are of double type, while there may be some target-typing involved (so float x = 1.0 should still work).

Maybe more thought should be put into target-typing of expressions?

@ForNeVeR ForNeVeR mentioned this issue Aug 17, 2022
Merged
1 task
@kant2002 kant2002 mentioned this issue Aug 19, 2022
Merged
1 task
@kant2002 kant2002 mentioned this issue Aug 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:cil-interop Related to CIL (.NET) interop area:compiler Related to code compilation or type checking kind:feature New feature or request status:help-wanted Open for contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add typecast expression kant2002/Cesium
1 participant
@ForNeVeR