Add typecast expression #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make typecast explicit operation in the IR. - Due to fact that `IDeclarationScope` is inaccessible during Lower call. I put explicit typecasts during emit phase. That require subsequet changes in `IExpression` interface and possible in the `ToIntermediate` as well. - `BinaryOperatorExpression.EmitConversion` consult now `CTypeSystem`, I plan to remove that method altogether and replace it by insertion of corresponding `TypeCastExpression` when needed. - Changes in `PrimitiveTypes` test is artifact of typecast insertion. Once constant evaluation would start appearing, I expect changes in these area again. Same for `FloatConstTest2`, it will emit ldc.r4 becasue `(float)1.5` would be folded directly to `1.5f` I did not close ForNeVeR#246 with that PR because I need to invest in more tests for conversions, and rework of `ArithmeticBinaryOperatorExpression` to insert `TypeCastExpression`. Basically I expect during lowering following conversion `IntConstant(1) + CharConstant('c')` => `IntegerConstant(1) + IntegerConstant(99)`, but introduction of `TypeCastExpression` is allow to work on that issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDeclarationScopeis inaccessible during Lower call. I put explicit typecasts during emit phase. That require subsequet changes inIExpressioninterface and possible in theToIntermediateas well.BinaryOperatorExpression.EmitConversionconsult nowCTypeSystem, I plan to remove that method altogether and replace it by insertion of correspondingTypeCastExpressionwhen needed.PrimitiveTypestest is artifact of typecast insertion. Once constant evaluation would start appearing, I expect changes in these area again. Same forFloatConstTest2, it will emit ldc.r4 becasue(float)1.5would be folded directly to1.5fI did not close #246 with that PR because I need to invest in more tests for conversions, and rework of
ArithmeticBinaryOperatorExpressionto insertTypeCastExpression. Basically I expect during lowering following conversionIntConstant(1) + CharConstant('c')=>IntegerConstant(1) + IntegerConstant(99), but introduction ofTypeCastExpressionis allow to work on that issue.Closes: #243