Add bunch of test cases #183
Conversation
kant2002
commented
Aug 8, 2022
kant2002
commented
- Add both working, and not yet working snippets of C
- Add support for recursive dir traversal in integration testing. Will need this for more tests to C runtime
|
At least 1 test should be removed after #185 lands, since I have basically duplicate test. |
Cesium.Compiler/stdlib/stdio.h
Outdated
| void printf(char* s) { | ||
| // That's temporary until varargs would not be implemented. | ||
| // no formatting obviously. | ||
| puts(s); | ||
| } |
There was a problem hiding this comment.
I'm not sure if it is valid for stdio.h to define the function body in a header file.
Also, this deserves a TODO comment (I'm creating an issue for each merged TODO).
There was a problem hiding this comment.
Okay. that PR is kitchen sink of different failed attempts to find some place where I can have quick win. I will try to cleanup it which is quite possible, but still it reply on earlier RPs which I send, so I waiting for them to land. I will let you know when this would be ready for your attention.
There was a problem hiding this comment.
For such cases, you may consider marking a PR as a "draft". This way, you formally let me know that it is not yet ready to merge.
An example of a draft PR is #139.
There was a problem hiding this comment.
Yeah, I was lazy when I create it, but cannot convert PR to draft after creation. Maybe that's some permission issue, or require some setup?
There was a problem hiding this comment.
Sorry, I'm not sure what the rules about drafts are, but I've found that I can convert it myself. So I did.
Let me know if you want to un-draft this, and cannot do it yourself.
There was a problem hiding this comment.
What's your opinion on this printf implementation? Should we still merge it being in a header file?
There was a problem hiding this comment.
I would like to have Cesium.Runtime to be something minimal and provide as much implementation in C as possible. Example of functions which maybe written in C is atoi/ioa, we almost at the point where we can write them in C. Maybe that's require have something like stdlib.c which would be added automatically by compiler. That's just example, not something which I think though.
For marketing reasons, I think we should have printf even with limitation as serious as it is right now. Technically right now we don't have "Hello World".
There was a problem hiding this comment.
My whole point is that in C, you cannot write code in headers.
If we want to write C stdlib (how do you distinguish it from Cesium.Runtime, by the way?), then we'll have to do it in .c files, and link them somehow with the user's program.
For now, this is too much. Let's migrate this to the Cesium.Runtime, and create a separate issue to discuss details of implementation parts of the standard library in C.
| public static int Abs(int value) | ||
| { | ||
| if (value == int.MinValue) return int.MinValue; | ||
| return Math.Abs(value); | ||
| } |
There was a problem hiding this comment.
Wow that's a gimmick. Let's write a unit test for the standard library, then?
There was a problem hiding this comment.
Maybe we can, but I mostly think that should do that as part of "acceptance testing", but in retrospection after I think a bit on this I do agree with you. That's subsystem should be tested.
|
Abs is parsing INT_MIN. Fixed. |
|
Ooh, abs is also requires nested |
kant2002
force-pushed
the
kant/add-bunch-test-cases
branch
from
38ce4dd to
f2093e0
Compare
|
Now it's waiting for #189 only |
ForNeVeR
force-pushed
the
kant/add-bunch-test-cases
branch
from
f2093e0 to
a79cb4c
Compare
- Add both working, and not yet working snippets of C - Add support for recursive dir traversal in integration testing. Will need this for more tests to C runtime
kant2002
force-pushed
the
kant/add-bunch-test-cases
branch
from
a79cb4c to
c7ceafc
Compare
