[14.0][FIX] rma: fix reserving not available quantity #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidJForgeFlow
force-pushed
the
14.0-fix-rma_reservations
branch
2 times, most recently
from
09b222c to
7e6749e
Compare
DavidJForgeFlow
force-pushed
the
14.0-fix-rma_reservations
branch
from
7e6749e to
6854f01
Compare
|
I am not sure about the new dependency. Is it a glue module too hard to be done? |
I think it should be added in the base version, as the way it is working now overrides reservations (leading to create some pickings that cannot be validated nor cancelled or deleted). The changes done by the dependency could be added to RMA but I don't think that makes sense. |
|
Ok. I don't like to add dependencies in stable version but I am afraid there is no "clean" alternative. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid reserving units that are not available. Also ensures the lot picked is the correct one by adding a dependency to stock_move_forced_lot.
Previously, if for example, you try to deliver a unit with a lot not available in you stock, the stock move line will be created and you will no longer able to cancel, delete or validate that picking.
@LoisRForgeFlow