Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: first draft of i18n in authorize page #172

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matteo-cristino
Copy link
Collaborator

No description provided.

@matteo-cristino
Copy link
Collaborator Author

To see it use parent dev test in the wallet with italian language on

@matteo-cristino matteo-cristino linked an issue Oct 17, 2024 that may be closed by this pull request
Copy link
Member

@puria puria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's draft... generally we should support the .well-known credential languages

],
}
</script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/i18next/21.6.6/i18next.min.js"></script>
</head>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awww this is super needed! for .md descriptions especially! plz take it back!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems broken since require is not defined in the browser and after a bit of research it look like that, from the url we use to include tailwind, thi plugin is already included... but I just had a quick look, will have a better look at it

@@ -49,6 +43,36 @@
</div>
</main>
<script>
// i18n
const userLanguage = navigator.language || navigator.userLanguage;
const supportedLanguages = ['en-US', 'it-IT'];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this list should be taken from the .well-known

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add i18n and take care of lang on the authorize page
2 participants