Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FeaturedBadge name prop type #102

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JDMathew
Copy link
Contributor

Description

The name prop on the FeaturedBadge component was incorrect as it included all Logos. I have removed Simple logos as they are activated with the simple boolean prop.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run all builds, tests, and linting and all checks pass
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@JDMathew JDMathew requested a review from carbonrobot December 24, 2024 05:07
@JDMathew JDMathew self-assigned this Dec 24, 2024
Copy link

changeset-bot bot commented Dec 24, 2024

🦋 Changeset detected

Latest commit: 4ce58bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
formidable-oss-badges Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant