Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groq-builder: fixed a type issue with project #266

Merged
merged 8 commits into from
Mar 14, 2024
Merged

Conversation

scottrippey
Copy link
Member

@scottrippey scottrippey commented Feb 10, 2024

Description

When using the built files, the project method was causing a TypeScript error, like:
image

This has been fixed, and unit tests added.

Fixes #266 ;)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run all builds, tests, and linting and all checks pass
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Feb 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
groqd ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2024 2:17pm

Copy link

changeset-bot bot commented Mar 13, 2024

🦋 Changeset detected

Latest commit: d0adda3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
groq-builder Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@scottrippey scottrippey merged commit fd0ea62 into main Mar 14, 2024
5 checks passed
@scottrippey scottrippey deleted the fix/project-errors branch March 14, 2024 16:31
@github-actions github-actions bot mentioned this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants