This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
Zoom and Brush container fixes #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbolin
commented
Jun 1, 2017
| const originalDomain = this.getDomain(targetProps); | ||
| const currentDomain = defaults( | ||
| {}, targetProps.currentDomain || zoomDomain || originalDomain, domain | ||
| ); | ||
| const { x, y } = Selection.getSVGEventCoordinates(evt); | ||
| return [{ | ||
| target: "parent", | ||
| mutation: () => { | ||
| return { |
There was a problem hiding this comment.
no reason why onMouseDown needs to squash values for the various *domain props. this makes the this.getLastDomain fix work.
chrisbolin
commented
Jun 1, 2017
| @@ -0,0 +1,66 @@ | |||
| /*eslint-disable no-magic-numbers */ | |||
There was a problem hiding this comment.
A demo to work through bug reproductions. Intensionally not shown on the demo table of contents
This was referenced Jun 1, 2017
|
@chrisbolin this looks good to me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onMouseLeavewas firing for child elements. The fix ensure that the parentsvgwas left (not, e.g., the selected domainrect).zoomDomainchanges; it would revert back to internally cached values once zoom interactions (zoom/pan) resumed. The fix ensures that internal values are updated when outside changes happen.