This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
make ZoomContainer work with real-time data #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbolin
commented
Jul 14, 2017
| @@ -131,12 +132,23 @@ export const zoomContainerMixin = (base) => class VictoryZoomContainer extends b | |||
| const childComponents = React.Children.toArray(props.children); | |||
There was a problem hiding this comment.
The fix must be in modifyChildren or another part of the VictoryZoomContainer; it cannot just go in the event handlers (found in zoom-helpers.js). This is because if new data is added to a chart, the handlers don't get fired, but we must know whether to show the new data or stay "zoomed in."
chrisbolin
commented
Jul 14, 2017
| domain = zoomDomain; | ||
| } else if (!zoomActive) { | ||
| // if user has zoomed all the way out, use the child domain | ||
| domain = child.props.domain; |
There was a problem hiding this comment.
child.props.domain is already calculated for us, so this approach has no new computational overhead.
|
@chrisbolin Approved! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes FormidableLabs/victory#646
@boygirl I'd love your thoughts on this. I don't think this is the perfect implementation - I found myself fighting the architecture a bit. I'll leave so comments in the code to explain why I made some of the choices. Totally happy to revisit this!
This approach doesn't added any extra domain calculations, so that's an upside :)