This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
Feature/data sorting prop #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 17, 2017
boygirl
suggested changes
Feb 17, 2017
src/victory-util/data.js
Outdated
| @@ -90,7 +90,25 @@ export default { | |||
| typeof y === "string" ? { _y: stringMap.y[y], yName: y } : {} | |||
| ); | |||
| }); | |||
| return this.cleanData(data, props); | |||
|
|
|||
| const sortedData = this.sortData(data, props.dataSort); | |||
There was a problem hiding this comment.
The prop should be called sortKey as it is in VictoryLine
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FormidableLabs/victory#254
Supports:
FormidableLabs/victory-pie#129
FormidableLabs/victory-docs#256
Implements access to a
dataSortprop which resorts data according to a comparator function.General thought - it might be a good idea for us to start marking private methods with
_privateMethod. Being new to the project, I end up having to do a lot ofgreping to find out what the actual public interface of a module is intended to be.