This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
#641 - Changes the propTypes for 'x' and 'y' props in VictoryLabel to accept percentage string values #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… accept percentage string values.
|
@jerridan Thanks for this change! I will cut a release either today or over the weekend. This change will be included. |
|
@boygirl Happy to contribute! Really liking this library :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improvement to resolve this issue: FormidableLabs/victory#641. The propTypes around the 'x' and 'y' props in VictoryLabel did not allow percentages, though setting percentages did work. The propTypes have been changed to allow string values as well as numbers.