Skip to content
This repository has been archived by the owner on Feb 19, 2022. It is now read-only.

Improvement/named exports #380

Merged
merged 25 commits into from
Jun 5, 2018
Merged

Improvement/named exports #380

merged 25 commits into from
Jun 5, 2018

Conversation

boygirl
Copy link
Contributor

@boygirl boygirl commented Jun 3, 2018

This PR contains breaking changes!

  • adds support for minDomain and maxDomain. closes minDomain and maxDomain victory#1008
  • changes how domainPadding works (no longer constrains padding to existing quadrants) closes Don't coerce domainPadding to existing quadrant victory#1009
  • refactors all util methods to use named exports (except events which needs to be bound to context anyway)
  • generalizes and removes methods where possible, and moves a few axis specific methods to victory-chart
  • significantly refactors Domain methods
  • significantly refactors Data methods
  • Upgrade to react-fast-compare@^2.0.0 (now returns false for non-identical functions)
  • Less aggressive shouldComponentUpdate logic. Now only checks on primitive component props

@boygirl boygirl merged commit 5d96c10 into master Jun 5, 2018
@boygirl boygirl deleted the improvement/named-exports branch June 5, 2018 03:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't coerce domainPadding to existing quadrant minDomain and maxDomain
1 participant