Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VictoryLegend breaks when using VictoryLabel with text prop #1291

Closed
4 tasks done
wootencl opened this issue Apr 10, 2019 · 2 comments · Fixed by #1293
Closed
4 tasks done

VictoryLegend breaks when using VictoryLabel with text prop #1291

wootencl opened this issue Apr 10, 2019 · 2 comments · Fixed by #1293

Comments

@wootencl
Copy link

Checklist

  • This is not a victory-native specific issue. (Issues that only appear in victory-native should be opened here)

  • I have read through the FAQ and Guides before asking a question

  • I am using the latest version of Victory

  • I've searched open issues to make sure I'm not opening a duplicate issue

The Problem

Title pretty much says it but at current VictoryLegend will throw an Invarient Violation when VictoryLabel with a text prop is specified as the labelComponent.

Reproduction

https://codesandbox.io/s/5vmm8ov56x
@boygirl
Copy link
Contributor

boygirl commented Apr 10, 2019

Yikes! Thanks for the reproduction. I'll look into this today

@boygirl boygirl mentioned this issue Apr 10, 2019
Merged
@wootencl wootencl changed the title VictoryLegend breaks when using VictoryLabel with text prop VictoryLegend breaks when using VictoryLabel with text prop Apr 10, 2019
@wootencl
Copy link
Author

No problem! Thanks again for the super quick turnaround

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure VictoryLegend does not try to render a label for the dataKey "all" FormidableLabs/victory
2 participants
@boygirl @wootencl