Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure VictoryLegend does not try to render a label for the dataKey "all" #1293

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Ensure VictoryLegend does not try to render a label for the dataKey "all" #1293

merged 1 commit into from
Apr 10, 2019

Conversation

boygirl
Copy link
Contributor

@boygirl boygirl commented Apr 10, 2019 •
edited
Loading

This PR fixes #1291

@boygirl boygirl changed the title filter all key from labelComponents Ensure VictoryLegend does not render a label for the eventKey "all" Apr 10, 2019
@boygirl boygirl changed the title Ensure VictoryLegend does not render a label for the eventKey "all" Ensure VictoryLegend does not try to render a label for the dataKey "all" Apr 10, 2019
@boygirl boygirl merged commit f8dfe29 into master Apr 10, 2019
@boygirl boygirl deleted the bug/legend-text branch April 10, 2019 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VictoryLegend breaks when using VictoryLabel with text prop
1 participant
@boygirl