Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement/victory native stability #1062

Merged
merged 6 commits into from
Jul 27, 2018
Merged

Improvement/victory native stability #1062

merged 6 commits into from
Jul 27, 2018

Conversation

boygirl
Copy link
Contributor

@boygirl boygirl commented Jul 27, 2018

this PR

  • Adds the ability to set a clipPath prop on all primitive components
  • generates all keys based on name prop or id prop (primitive components and labels)

This should not be a breaking change, but it may break snapshot tests as keys for most victory components have changed.

@boygirl boygirl merged commit 1e84faa into master Jul 27, 2018
@boygirl boygirl deleted the improvement/victory-native-stability branch July 27, 2018 16:25
@luciomartinez luciomartinez mentioned this pull request Dec 14, 2018
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@boygirl