Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow closed curves for cartesian charts #1135

Merged
merged 1 commit into from
Oct 3, 2018

Conversation

boygirl
Copy link
Contributor

@boygirl boygirl commented Oct 3, 2018

@HalHaig This PR allows closed curves for cartesian charts.

polar charts will still default to closed interpolation, and cartesian charts will still default to open interpolations. To change this behavior:

<VictoryLine
  dataComponent={<Curve openCurve={false} />}
  ...
/>

@boygirl boygirl merged commit f178ea1 into master Oct 3, 2018
@boygirl boygirl deleted the improvement/allow-non-polar-closed-curves branch October 3, 2018 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant