Improve performance for addEventKeys #1208
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I improved the performance of my charts with large datasets significantly by changing the
getEventKey
function in away that a new object is only created wheneventKey
is set in theprops
.My reasoning for this change is:
eventKey
field, assign adds nothing.eventKey
the fallback can be (and already is in most cases) performed in the ComponentsgetBaseProps
.eventKey
is computed the old behavior is required.In my use case the perfomance of chart updates nearly doubled.